-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Merkle tree pruning for the wallet #353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupremoUGH
added
the
changelog:added
Changelog: add these changes to the `added` section of the changelog
label
Jun 5, 2023
SupremoUGH
changed the title
Reinstore pruning good
Restore Merkle tree pruning for the wallet
Jun 5, 2023
3 tasks
Apokalip
previously approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt, I dont know if its not a bad idea to have tests for the leaf indexes(reviewer note)
zqhxuyuan
reviewed
Jun 8, 2023
zqhxuyuan
reviewed
Jun 9, 2023
Apokalip
approved these changes
Jun 9, 2023
zqhxuyuan
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenables the Merkle tree pruning functionality for the wallet, this time as a BTreeMap instead of vec, which allows for almost 100% saved space (as opposed to 50%). Fixes some things in
fork
which were incompatible with pruning, as well as some indexing issues which were incompatible with the branches.Should also speed up sync time because of the batch optimization when merging a branch into its trunk. Not now, see the issue: #354
Goes together with: Manta-Network/sdk#133
Note for reviewers
When reviewing, please make sure that the indexing is right, meaning: indexes in the Partial Merkle tree and indexes in its leaf map are off by
self.starting_leaf_index()
. Make sure each function is using the right index, depending on whether they are interacting with the tree or just with itsLeafMap
.Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.