Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial sync pruning fix #363

Merged
merged 12 commits into from
Aug 31, 2023
Merged

Initial sync pruning fix #363

merged 12 commits into from
Aug 31, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Aug 25, 2023 •
edited
Loading

Fixes a bug which was causing prune not to work on trees initialized by initial_sync.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH SupremoUGH self-assigned this Aug 25, 2023
@SupremoUGH SupremoUGH added the changelog:fixed Changelog: add these changes to the `fixed` section of the changelog label Aug 25, 2023
@SupremoUGH SupremoUGH changed the title bugfix Initial sync pruning fix Aug 25, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review August 25, 2023 09:53
ghzlatarev
ghzlatarev previously approved these changes Aug 25, 2023
View reviewed changes
@DanielZhangReal DanielZhangReal mentioned this pull request Aug 28, 2023
Merged
3 tasks
@ghzlatarev
Should not need the clone
c45c4db 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev dismissed stale reviews from DanielZhangReal and themself via c45c4db August 30, 2023 08:51
@ghzlatarev
Disable clippy for line
439e535 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Disable clippy in a few places
c5b7b05 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
try #[derivative(Clone(clone_trait = ::std::clone::Clone))]
bcb737c 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Remove etra clone|
2db0428 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Revert
4d76184 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Revert
7c0f1f2 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Revert
788cdab 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Skip the erroring lint for now'
1e47759 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Skip the erroring lint for now'
4196cc8 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev merged commit cc9223f into main Aug 31, 2023
@ghzlatarev ghzlatarev deleted the prune_init_sync_bug branch August 31, 2023 14:28
@ghzlatarev ghzlatarev mentioned this pull request Sep 1, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangReal DanielZhangReal DanielZhangReal approved these changes

@ghzlatarev ghzlatarev ghzlatarev approved these changes

Assignees

@SupremoUGH SupremoUGH

Labels
changelog:fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SupremoUGH @ghzlatarev @DanielZhangReal