Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade simulation to a CLI #58

Merged
merged 1 commit into from
May 2, 2022
Merged

feat: upgrade simulation to a CLI #58

merged 1 commit into from
May 2, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented May 2, 2022 •
edited
Loading

  • Adds full CLI for simulation parameters
  • Extends Simulation structure to clap CLI for composability in other CLI systems

@bhgomes bhgomes marked this pull request as ready for review May 2, 2022 22:37
BoyuanFeng
BoyuanFeng approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@BoyuanFeng BoyuanFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhgomes bhgomes merged commit 9e351ac into main May 2, 2022
@bhgomes bhgomes deleted the feat/simulation-cli branch May 2, 2022 23:53
BoyuanFeng pushed a commit that referenced this pull request Jun 2, 2022
@bhgomes
feat: upgrade simulation to a CLI (#58)
743853c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@Kevingislason Kevingislason Awaiting requested review from Kevingislason

@GhostOfGauss GhostOfGauss Awaiting requested review from GhostOfGauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhgomes @BoyuanFeng