Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Sample trait for Poseidon hash parameters & seperate LFSR as standalone RNG #87

Closed
wants to merge 9 commits into from

Conversation

tsunrise
Copy link
Contributor

@tsunrise tsunrise commented Jun 3, 2022

This PR aims to add more flexibility to the Poseidon Hash Parameter generation.

Goals

  • Implement Sample trait for AdditiveRoundConstants to allow custom RNG and distribution other than LFSR and rejection sampling.
  • Implement Sample trait for cauchy matrix and MDS, so custom MDS can be generated.
  • Make LFSR an RNG.
  • Update Sample trait for Poseidon
  • Rejection Sampling as a wrapper distribution.

Closes: #74


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@tsunrise tsunrise changed the title Implement Sample trait for Poseidon Hash Parameters & Seperate LFSR as standalone RNG feat: Implement Sample trait for Poseidon Hash Parameters & Seperate LFSR as standalone RNG Jun 8, 2022
@tsunrise tsunrise changed the title feat: Implement Sample trait for Poseidon Hash Parameters & Seperate LFSR as standalone RNG feat: implement Sample trait for Poseidon hash parameters & seperate LFSR as standalone RNG Jun 9, 2022
@bhgomes bhgomes modified the milestones: v1.1.0, Future Jun 9, 2022
@tsunrise tsunrise self-assigned this Jun 9, 2022
@bhgomes bhgomes added C-experiment Category: Experimental feature or tool P-low Priority: Low C-enhancement Category: An issue proposing an enhancement or a PR with one norelease A-design Area: Design of Libraries and APIs and removed norelease labels Jul 6, 2022
@stechu stechu closed this Dec 2, 2022
@bhgomes bhgomes deleted the feat/para_gen branch January 10, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-design Area: Design of Libraries and APIs C-enhancement Category: An issue proposing an enhancement or a PR with one C-experiment Category: Experimental feature or tool P-low Priority: Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poseidon Parameter Generation: Separate LFSR from Sampling Distribution/Algorithm
3 participants