feat: implement Sample
trait for Poseidon hash parameters & seperate LFSR as standalone RNG
#87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add more flexibility to the Poseidon Hash Parameter generation.
Goals
Sample
trait forAdditiveRoundConstants
to allow custom RNG and distribution other than LFSR and rejection sampling.Sample
trait for cauchy matrix and MDS, so custom MDS can be generated.LFSR
an RNG.Sample
trait for PoseidonCloses: #74
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.