-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pre existing connections to be used #20
Allow pre existing connections to be used #20
Conversation
8bdeeec
to
56dbc7e
Compare
Hey @nealio82, could you please bring this up-to-date with master now that we've fixed the build? |
56dbc7e
to
e161c00
Compare
hey @michaeljoseph, i rebased onto the updated master |
@noondaysun normally I'd have batch-applied your suggestions so you get onto the authors list as well, but the change in |
Depends on #19
This PR breaks the config into encapsulated classes and removes a lot of the coupling between the migrator and the
App
class. It allows injection of connections into the migrator, so pre-definedConnection
objects can be used, rather than requiring using theconfig.json
file. It is a first-step in tidying and abstracting some of the parts of the system, with the goal of moving toward SRP and cleaner APIs between objects.I've also added unit tests for some of the classes I've introduced, while being careful not to modify the existing integration test suite.