Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout when checking if a crate has been published #1015

Closed
MarcoIeni opened this issue Oct 1, 2023 · 4 comments · Fixed by #1088 or #1072
Closed

Add a timeout when checking if a crate has been published #1015

MarcoIeni opened this issue Oct 1, 2023 · 4 comments · Fixed by #1088 or #1072
Labels
bug Something isn't working

Comments

@MarcoIeni
Copy link
Owner

@orhun had the issue where this function never finished. We should add a timeout (1 minute?) so that at least we can report what the error is.

@MarcoIeni MarcoIeni added the bug Something isn't working label Oct 1, 2023
@orhun
Copy link
Contributor

orhun commented Oct 1, 2023

It gets stuck at this line:

index.update().context("failed to update git index")?;

@MarcoIeni
Copy link
Owner Author

I see. Probably we can debug and check inside that function.
Btw, I was expecting release-plz to use the sparse protocol, since it's the default for crates.io :/

@orhun
Copy link
Contributor

orhun commented Oct 1, 2023

So I ran strace and there are a bunch of (Connection timed out) errors after doing some operations in .cargo/registry/index (there are logs such as Compressing objects: 100%). Is there a proper way to get debug output from crates_index library?

@MarcoIeni
Copy link
Owner Author

Is there a proper way to get debug output from crates_index library?

I had a look at the codebase. It seems they don't emit any logs. 😢
I looked for strings such as logs, tracing, info!, error! but I didn't find anything.

ludusrusso added a commit to ludusrusso/release-plz that referenced this issue Nov 25, 2023
MarcoIeni added a commit that referenced this issue Nov 28, 2023
…1088)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Marco Ieni <11428655+MarcoIeni@users.noreply.github.com>
@release-plz release-plz bot mentioned this issue Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants