-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration: add ability to create releases as prerelease #678
Comments
Hi, I would like to work on this issue. I looked through #986 and did something similiar for github. From my understanding of the API this is only possible for github, is that correct? How do you usually test those things? I'm a newcomer and also new to Rust and would like to contribute more often. |
Hi! If gitea and gitlab don't have pre-releases, we can make this feature github only. Let's make it explicit in the doc 👍 Usually I test these things manually. |
Pr welcome! Release-plz is rust beginner-friendly, so no worries if the pr is not perfect |
From my understanding github and gitea API is the same. For gitlab I couldn't find anything similar, same goes for the draft release: I will test my code now and create an integration test. Could you guide me to the right place within the documentation? |
Sounds good! For the docs, you can add the new option here: https://release-plz.ieni.dev/docs/config Let's specify that this option will only work on github and gitea. |
I created #1228. This one misses the integration tests because we do not test the release action at moment at all and I don't really know where to start. |
Thanks for the PR, I will have a look 🙏 |
Okay thank you, I will take a look at it. I just found out that I broke this test and I don't know why. |
I fixed the test 👍 |
In the config file:
we already read this field from the config, but we don't use it:
release-plz/crates/release_plz/src/config.rs
Line 314 in 06418c1
You can take inspiration from #986
The text was updated successfully, but these errors were encountered: