Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pre-release option #1228

Merged
merged 12 commits into from
Jan 25, 2024
Merged

Conversation

ybaldus
Copy link
Contributor

@ybaldus ybaldus commented Jan 24, 2024

Closes #678

This pull request adds the ability to set a release type mode for GitHub and Gitea. It uses the modes which where defined beforehand:

  • Prod: ready for production
  • Pre: pre-release
  • Auto: pre-release detection based on a semver version within the git tag

@MarcoIeni MarcoIeni marked this pull request as ready for review January 24, 2024 21:56
@MarcoIeni
Copy link
Owner

The rest looks great! If you want to also write an integration test it's up to you.
Otherwise, if you address that comment, this PR is ready to be merged.
You can also add the test in a later PR if you prefer.
Did you test this manually?

@ybaldus
Copy link
Contributor Author

ybaldus commented Jan 24, 2024

Thank you for the feedback and the help!

I didn't test it yet. I will have to set up a seperate repo for that and I will have to look into the cargo release. That's why I set this as draft. I will leave for vacation and thought it might be better to open the PR before.

@MarcoIeni
Copy link
Owner

I tested it on gitea and it works, thanks!
image
I will merge this, so that we ship this feature earlier. If you want you can submit another PR to add the test

@MarcoIeni MarcoIeni merged commit 23bbc4f into MarcoIeni:main Jan 25, 2024
13 checks passed
@release-plz release-plz bot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration: add ability to create releases as prerelease
2 participants