Can't publish to private registry (works with cargo publish)

[scullionw]

Bug description

Can't publish to private registry (works with cargo publish)

Expected behavior

I would expect the crates to be published like they are with cargo publish or cargo release

Screenshots

Environment

• OS: macOS 13.3
• release-plz version: release-plz 0.3.14

[MarcoIeni]

Thanks for the report, I will try to reproduce and fix this 👍

[Kelwing]

@MarcoIeni I looked into this because I was running into the same issue. It's caused when the private registry is configured using a sparse protocol url instead of a git url. release-plz only uses the git index fromcrates_index and tries to initialize the Index object from a sparse registry URL.
https://github.com/MarcoIeni/release-plz/blob/main/crates/release_plz_core/src/command/release.rs#L315

[MarcoIeni]

Thanks for looking into this. I'll try to look into this next week.
In the meantime, if you have a proposal on how to fix it let me know :)

[MarcoIeni]

I'm trying to check if #863 fixed this issue.

• scullionw, can you try if that branch fixes your issue?
• Kelwing, can you tell me how have you tested it?

I registered to shipyard.rs, I added this to my .cargo/config.toml:

[registries.ieni]
index = "ssh://git@ssh.shipyard.rs/ieni/crate-index.git"

[net]
git-fetch-with-cli = true

[http]
user-agent = "shipyard <token>"

and I created an ssh key pair.

However both release-plz and cargo publish are failing for me.

$ cargo publish --registry ieni
    Updating `ieni` index
git@ssh.shipyard.rs: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: failed to update registry `ieni`

Caused by:
  failed to fetch `ssh://git@ssh.shipyard.rs/ieni/crate-index.git`

Caused by:
  process didn't exit successfully: `git fetch --force --update-head-ok 'ssh://git@ssh.shipyard.rs/ieni/crate-index.git' '+HEAD:refs/remotes/origin/HEAD'` (exit status: 128)

Probably I'm missing something from the configuration.

[Kelwing]

@MarcoIeni Sparse registry indexes don't use get, they use https. A sparse index URL will start with sparse+https. You should be able to test this with crates.io by specifying sparse+https://index.crates.io/ as your registry index.

https://doc.rust-lang.org/cargo/reference/registry-index.html#sparse-protocol

[MarcoIeni]

ok, thanks, I will test this. However, from scullionw's screenshot, I see he is not using a sparse registry (I see a git@ssh).
Do you think your PR fixes his issue?

[MarcoIeni]

reopening, because I'm not sure the linked pr fixed the issue

[Kelwing]

That's the same behavior and error I was seeing when I tried using a sparse URL without support for it. The crate_index package would attempt to treat it as if it were a git repo. I do feel it would be appropriate for this issue to be left open until the author can verify that the PR fixed it for them, and they are able to provide more information about whether or not they are using a sparse index.

[MarcoIeni]

In #892 I added a test where I publish a crate to the gitea private cargo registry which runs in docker.
This demonstrates that release-plz can publish to private registries, so I'm closing this issue.
If you find issues with other cargo registries, please open another issue with a step-by-step reproduction guide (e.g. register to this website, click here, use a certain config.toml, etc.).
Thanks everyone 🙏