Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(release): add support for sparse registry URLs #863

Merged
merged 6 commits into from
Jul 25, 2023
Merged

feat(release): add support for sparse registry URLs #863

merged 6 commits into from
Jul 25, 2023

Conversation

Kelwing
Copy link
Contributor

@Kelwing Kelwing commented Jul 20, 2023

Adds support for sparse registry URLs, fixes #831.

@MarcoIeni
Copy link
Owner

thank you so much. Looks very good! I just left a comment

@Kelwing Kelwing requested a review from MarcoIeni July 21, 2023 16:11
MarcoIeni
MarcoIeni reviewed Jul 22, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@MarcoIeni
Copy link
Owner

In aece670 I removed some duplicate code. If you like these changes, can you apply them to your branch?
Sorry for the manual task, but I didn't know a better way to propose these changes to your pr :(

@MarcoIeni
Copy link
Owner

the code looks good! I will test this and it if works, I will merge it 👍

@MarcoIeni MarcoIeni mentioned this pull request Jul 23, 2023
Closed
@MarcoIeni
Copy link
Owner

tested by adding

[registries.crates-io-http]
index = "sparse+https://index.crates.io/"

to .cargo/config.toml and running release-plz release --registry crates-io-http.
It worked! Thanks so much for this contribution. 🙏

@MarcoIeni MarcoIeni changed the title add support for sparse registry URLs feat: add support for sparse registry URLs Jul 25, 2023
@MarcoIeni MarcoIeni changed the title feat: add support for sparse registry URLs feat(release): add support for sparse registry URLs Jul 25, 2023
@MarcoIeni MarcoIeni enabled auto-merge (squash) July 25, 2023 17:45
@MarcoIeni MarcoIeni merged commit bb7053c into MarcoIeni:main Jul 25, 2023
10 checks passed
@release-plz release-plz bot mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoIeni MarcoIeni MarcoIeni left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't publish to private registry (works with cargo publish)
2 participants
@Kelwing @MarcoIeni