Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent typos in overrides #1080

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

mre
Copy link
Contributor

@mre mre commented Nov 19, 2023

Fixes #673

@mre mre force-pushed the feature/prevent-typos-in-overrides branch 2 times, most recently from 716fde0 to 73d124c Compare November 19, 2023 23:22
@mre mre force-pushed the feature/prevent-typos-in-overrides branch from d181ae1 to 6249e09 Compare November 19, 2023 23:32
@MarcoIeni
Copy link
Owner

Great work, thanks! I slightly changed the tests because we aren't testing wrong dependency names, but just wrong package names.
I hope you don't mind I did this small change by myself :)

@MarcoIeni MarcoIeni enabled auto-merge (squash) November 23, 2023 18:14
@MarcoIeni MarcoIeni merged commit 346dd37 into MarcoIeni:main Nov 23, 2023
13 checks passed
@release-plz release-plz bot mentioned this pull request Nov 23, 2023
@mre mre deleted the feature/prevent-typos-in-overrides branch November 23, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return error if configuration file contains configuration for a package that doesn't exist
2 participants