Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass commit ids to git-cliff #967

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

aschey
Copy link
Contributor

@aschey aschey commented Sep 15, 2023

Resolves #954

This change passes the commit IDs to git-cliff when the changelog is generated, allowing users to use commit IDs in their changelog formats.

When using a commit message without an actual commit, I changed the placeholder value to "N/A", indicating there is no corresponding commit ID available. Happy to discuss this further if you'd like to handle this case differently.

@MarcoIeni
Copy link
Owner

This is awesome, thanks! 🙌
Just one change request: can you put "N/A" into a const and write your explanation as a comment ("there is no corresponding commit ID available")?
So that "N/A" isn't duplicated across the codebase and we avoid typos 👍

@aschey
Copy link
Contributor Author

aschey commented Sep 15, 2023

This is awesome, thanks! 🙌 Just one change request: can you put "N/A" into a const and write your explanation as a comment ("there is no corresponding commit ID available")? So that "N/A" isn't duplicated across the codebase and we avoid typos 👍

Very good point, made that change and fixed the clippy error.

@MarcoIeni MarcoIeni enabled auto-merge (squash) September 16, 2023 05:10
@MarcoIeni MarcoIeni merged commit fa0ee16 into MarcoIeni:main Sep 16, 2023
13 checks passed
@MarcoIeni
Copy link
Owner

Thank you 🥳

@release-plz release-plz bot mentioned this pull request Sep 16, 2023
@aschey aschey deleted the commit-ids branch September 16, 2023 14:54
@aschey
Copy link
Contributor Author

aschey commented Sep 16, 2023

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass commit IDs to git-cliff
2 participants