Skip to content

Commit

Permalink
Deprecate ambiguous svids_count field in Agent GetDebug API
Browse files Browse the repository at this point in the history
Introduce new SVID count fields for each SVID cache in SPIRE Agent.
These new fields clarify what exactly is represented in the counts and
provide integration tests a way to assert on the state of the various
Agent in-memory caches.

Signed-off-by: Ryan Turner <turner@uber.com>
  • Loading branch information
Ryan Turner authored and MarcosDY committed Sep 10, 2024
1 parent 9701b78 commit c51a5c7
Show file tree
Hide file tree
Showing 2 changed files with 75 additions and 26 deletions.
92 changes: 67 additions & 25 deletions proto/spire/api/agent/debug/v1/debug.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion proto/spire/api/agent/debug/v1/debug.proto
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,14 @@ message GetInfoResponse {
// Agent uptime in seconds
int32 uptime = 2;
// Number of SVIDs cached in memory
int32 svids_count = 3;
// Deprecated in favor of cached_x509_svids_count, cached_jwt_svids_count, and cached_svidstore_x509_svids_count
int32 svids_count = 3 [deprecated=true];
// last successful sync with server (in seconds since unix epoch)
int64 last_sync_success = 4;
// Number of X.509-SVIDs in Agent primary in-memory cache
int32 cached_x509_svids_count = 5;
// Number of JWT-SVIDs in Agent primary in-memory cache
int32 cached_jwt_svids_count = 6;
// Number of X.509-SVIDs in Agent svidstore in-memory cache
int32 cached_svidstore_x509_svids_count = 7;
}

0 comments on commit c51a5c7

Please sign in to comment.