Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix votekick threshold due to API change #677

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix votekick threshold due to API change #677

merged 1 commit into from
Sep 4, 2024

Conversation

Dorfieeee
Copy link
Collaborator

The frontend failed to handle the POST /api/set_votekick_thresholds request because the endpoint now expects an [int, int][] array in version 10, whereas it accepted a string in version 9.

cemathey
cemathey approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@cemathey cemathey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe I didn't notice this when I was looking at it, I only looked on the backend

@cemathey cemathey merged commit 030fe47 into master Sep 4, 2024
@cemathey cemathey deleted the frontend/votekick-thresholds branch September 4, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cemathey cemathey cemathey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dorfieeee @cemathey