Feat/seed vip #682
Merged
Feat/seed vip #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been running this for a few days on ours; looks to be working fine. |
ElGuillermo
reviewed
Sep 19, 2024
There was a problem hiding this comment.
This is the "GTX Server Name Change" doc ;)
FlorianSW
reviewed
Sep 22, 2024
| @cli.command(name="seed_vip") | ||
| def run_seed_vip(): | ||
| config = SeedVIPUserConfig.load_from_db() | ||
| if config.enabled: |
There was a problem hiding this comment.
won't this result in automatic restarts when the seed vip feature is disabled? (I mean supervisor restarting the service)
| logger.debug( | ||
| f"Did not receive a usable result from `get_online_players`, continuing" | ||
| ) | ||
| continue |
There was a problem hiding this comment.
Shouldn't be a sleep here as well? Otherwise the loop will re-reun this code instantly, isn't it?
| logger.debug( | ||
| f"Did not receive a usable result from `get_gamestate`, continuing" | ||
| ) | ||
| continue |
There was a problem hiding this comment.
same as the comment before.
FlorianSW
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty straight forward port of https://github.com/cemathey/hll_seed_vip to run as a service inside of CRCON itself.
Made some minor tweaks since it can access info internally instead of using the API.
This runs as a separate service (like all the other plugins)
Has a user config and updated menu
Opening a draft PR; I'm going to set this up in dry run mode on ours and verify that I get the same results as my externally hosted one, then again the next day with dry run off and the other tool in dry run and verify again.
For future reference, this possible languages that can be used when using
humanizeto nicely format date/time quantities: https://github.com/MarechJ/hll_rcon_tool/wiki/Seed-VIP-Localization