More arches (ppc64le + arm64v8) and ubuntu #184

yosifkit · 2018-07-17T00:00:46Z

--- /dev/fd/63	2018-07-16 16:58:06.581643956 -0700
+++ /dev/fd/62	2018-07-16 16:58:06.578643898 -0700
@@ -1,25 +1,30 @@
-# this file is generated via https://github.com/docker-library/mariadb/blob/9ce4ecd2783d2358d2c0fe0efa924ecae33d9e84/generate-stackbrew-library.sh
+# this file is generated via https://github.com/docker-library/mariadb/blob/852044c20cd24a94bb15d8fcdb7b0784a40110d9/generate-stackbrew-library.sh
 
 Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon),
              Joseph Ferguson <yosifkit@gmail.com> (@yosifkit)
 GitRepo: https://github.com/docker-library/mariadb.git
 
-Tags: 10.3.8-jessie, 10.3-jessie, 10-jessie, jessie, 10.3.8, 10.3, 10, latest
-GitCommit: a7d1a184913c009c473baeb8f72385d12ae0de61
+Tags: 10.3.8-bionic, 10.3-bionic, 10-bionic, bionic, 10.3.8, 10.3, 10, latest
+Architectures: amd64, arm64v8, ppc64le
+GitCommit: 852044c20cd24a94bb15d8fcdb7b0784a40110d9
 Directory: 10.3
 
-Tags: 10.2.16-jessie, 10.2-jessie, 10.2.16, 10.2
-GitCommit: 1e7c5c9bb2bfde0453fb52175343a360ed346104
+Tags: 10.2.16-bionic, 10.2-bionic, 10.2.16, 10.2
+Architectures: amd64, arm64v8, i386, ppc64le
+GitCommit: 852044c20cd24a94bb15d8fcdb7b0784a40110d9
 Directory: 10.2
 
-Tags: 10.1.34-jessie, 10.1-jessie, 10.1.34, 10.1
-GitCommit: 12a0273332a3a0ed007ece2ae5886f7ac9c15d1b
+Tags: 10.1.34-bionic, 10.1-bionic, 10.1.34, 10.1
+Architectures: amd64, arm64v8, ppc64le
+GitCommit: 852044c20cd24a94bb15d8fcdb7b0784a40110d9
 Directory: 10.1
 
-Tags: 10.0.35-jessie, 10.0-jessie, 10.0.35, 10.0
-GitCommit: 20b1413b646df9a45df2d4dcc5c5c89ecb42c0b1
+Tags: 10.0.35-xenial, 10.0-xenial, 10.0.35, 10.0
+Architectures: amd64, arm64v8, i386, ppc64le
+GitCommit: 852044c20cd24a94bb15d8fcdb7b0784a40110d9
 Directory: 10.0
 
-Tags: 5.5.60-wheezy, 5.5-wheezy, 5-wheezy, 5.5.60, 5.5, 5
-GitCommit: 20b1413b646df9a45df2d4dcc5c5c89ecb42c0b1
+Tags: 5.5.60-trusty, 5.5-trusty, 5-trusty, 5.5.60, 5.5, 5
+Architectures: amd64, i386, ppc64le
+GitCommit: 852044c20cd24a94bb15d8fcdb7b0784a40110d9
 Directory: 5.5

Closes #175
Closes #158
Closes #155
Closes #111

…le so that the jenkins job doesn't need changes

tianon · 2018-07-17T22:19:17Z

10.0/Dockerfile

@@ -24,6 +37,7 @@ RUN set -ex; \
 	export GNUPGHOME="$(mktemp -d)"; \
 	gpg --keyserver ha.pool.sks-keyservers.net --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4; \
 	gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu; \
+	{ command -v gpgconf > /dev/null && gpgconf --kill all || :; }; \


{ and } aren't needed here since we're already in a semi-colon-ized block (only need those in a series of &&) 😇

tianon · 2018-07-17T22:20:48Z

10.0/Dockerfile

-		echo 'Pin-Priority: 998'; \
-	} > /etc/apt/preferences.d/percona
-
+# bashbrew-architectures: ppc64le i386 amd64 arm64v8


This ordering is a little odd -- is this just the order Bash spits them out? I wonder if it'll change from Bash version to version (hopefully not).

tianon · 2018-07-17T22:22:10Z

10.1/Dockerfile

-	&& apt-get update \
-	&& apt-get install -y \
+	} | debconf-set-selections; \
+	XTRABACKUP='mariadb-backup-10.1'; \


Can we call this variable just backupPackage or something instead? (since it's now preferred to not use xtrabackup if we can avoid it?)

tianon · 2018-07-17T22:24:08Z

update.sh

 )
+declare -A dpkArchToBashbrew=(


dpkArchToBashbrew should be dpkgArchToBashbrew

tianon · 2018-07-17T22:26:09Z

update.sh

+		if ver="$(getRemoteVersion "$version" "$suite" "$arch")" && [ -n "$ver" ]; then
+			arches="$arches ${dpkArchToBashbrew[$arch]}"
+		fi
+	done


tianon · 2018-07-20T19:23:35Z

Yay docker-library/php#666 🎉 🍰

…parsing Also adjust travis to use pgp-happy-eyeballs

tianon · 2018-07-20T20:14:21Z

Let's do this.

grooverdan · 2018-07-21T08:14:05Z

@yosifkit and @tianon thanks for much for making this happen.

klausenbusk · 2018-07-31T09:19:58Z

10.1/Dockerfile

-	&& apt-get update \
-	&& apt-get install -y \
+	} | debconf-set-selections; \
+	backupPackage='mariadb-backup-10.1'; \


Thanks for breaking our existing Galera setup without warning... A heads-up next time will be nice.

I'm definitely sorry that your setup broke, but to say it was "without warning" is a little bit much.

We only have two ways of informing users of changes to images -- PRs/issues on this repository, and PRs with the library/mariadb label on the official-images repository, of which this change had both, so there's unfortunately really not much more "heads-up" we could provide.
Additionally, I'd heartily recommend setting up some kind of testing environment where you can test image updates before deploying them to ensure that this sort of breakage doesn't affect you in the future.

All that being said, breaking folks wasn't an intention of this change, so it sounds like we need to do more to adapt this. Can you provide more detail about what your setup looks like and how this broke it? Ideally we'd love a couple simplified commands or a compose/stack YAML that can reproduce the failure.

I'm definitely sorry that your setup broke, but to say it was "without warning" is a little bit much.

I'm sorry it came out a bit harsh.

We only have two ways of informing users of changes to images -- PRs/issues on this repository, and PRs with the library/mariadb label on the official-images repository, of which this change had both, so there's unfortunately really not much more "heads-up" we could provide.

You are correct, but the change (xtrabackup -> mariabackup) should have been mentioned in the commit message (IMHO, its a breaking change).

Additionally, I'd heartily recommend setting up some kind of testing environment where you can test image updates before deploying them to ensure that this sort of breakage doesn't affect you in the future.

It didn't break the cluster, it only broke bootstrapping of new database nodes.

All that being said, breaking folks wasn't an intention of this change, so it sounds like we need to do more to adapt this. Can you provide more detail about what your setup looks like and how this broke it? Ideally we'd love a couple simplified commands or a compose/stack YAML that can reproduce the failure.

Galera use SST for the initial node bootstrapping and you can choose between mysqldump, rsync or xtrabackup/mariabackup. So when xtrabackup was removed, you broke the xtrabackup SST method. It was easy to fix by switching to the mariabackup SST method.

@klausenbusk do you think that we should add a symlink for xtrabackup to mariabackup like you had in #158 or should we just leave it as is?

@klausenbusk do you think that we should add a symlink for xtrabackup to mariabackup like you had in #158 or should we just leave it as is?

Just leave it as it is, a symlink wouldn't solve it anyway.

tianon · 2018-08-02T19:09:15Z

Just to thread the needle, there were some minor issues with this on arm64v8 which were fixed by #195.

yosifkit added 4 commits July 13, 2018 13:56

Move to Ubuntu based images in preparation for more arches

92a8133

Add arch support! (some of amd64, arm64v8, i386, ppc64le)

852044c

Add tzdata for zoneinfo

b9725e3

Lists the upstream arches in the Dockerfile rather than a separate fi…

2d44d8d

…le so that the jenkins job doesn't need changes

tianon reviewed Jul 17, 2018

View reviewed changes

yosifkit force-pushed the more-arches-also-ubuntu branch 2 times, most recently from 097d434 to 6538ae6 Compare July 20, 2018 19:23

tianon mentioned this pull request Jul 20, 2018

Base MariaDB 10.3 image of Debian Stretch (slim) #187

Closed

Makes backup variable name generic; sorts arch list for easier human …

195c843

…parsing Also adjust travis to use pgp-happy-eyeballs

yosifkit force-pushed the more-arches-also-ubuntu branch from 6538ae6 to 195c843 Compare July 20, 2018 19:29

tianon merged commit 61d3f34 into MariaDB:master Jul 20, 2018

tianon deleted the more-arches-also-ubuntu branch July 20, 2018 20:14

grooverdan mentioned this pull request Jul 21, 2018

support ppc64le architecture #154

Closed

This was referenced Jul 24, 2018

support arm64 architecture #125

Closed

Update cassandra, drupal, ghost, haproxy, julia, mariadb, pypy, and python docker-library/official-images#4634

Merged

mmarmm mentioned this pull request Jul 27, 2018

ARM64 Support docker-library/percona#62

Closed

klausenbusk reviewed Jul 31, 2018

View reviewed changes

yosifkit mentioned this pull request Aug 21, 2018

Add ARM64v8 support to xwiki docker-library/official-images#4723

Merged

tianon mentioned this pull request Dec 31, 2018

Use Debian:stretch-slim for newer images #121

Closed

J0WI mentioned this pull request May 17, 2021

Add Alpine variant #343

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More arches (ppc64le + arm64v8) and ubuntu #184

More arches (ppc64le + arm64v8) and ubuntu #184

yosifkit commented Jul 17, 2018 •

edited by tianon

Loading

tianon Jul 17, 2018

tianon Jul 17, 2018

tianon Jul 17, 2018

tianon Jul 17, 2018

tianon Jul 17, 2018

tianon commented Jul 20, 2018

tianon commented Jul 20, 2018

grooverdan commented Jul 21, 2018

klausenbusk Jul 31, 2018

tianon Jul 31, 2018

klausenbusk Aug 3, 2018

yosifkit Aug 6, 2018

klausenbusk Aug 7, 2018

tianon commented Aug 2, 2018

		)
		declare -A dpkArchToBashbrew=(

More arches (ppc64le + arm64v8) and ubuntu #184

More arches (ppc64le + arm64v8) and ubuntu #184

Conversation

yosifkit commented Jul 17, 2018 • edited by tianon Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tianon commented Jul 20, 2018

tianon commented Jul 20, 2018

grooverdan commented Jul 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tianon commented Aug 2, 2018

yosifkit commented Jul 17, 2018 •

edited by tianon

Loading