Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting villagers in a minecart spawns zombie outside the minecart #10

Closed
Kasama opened this issue Apr 10, 2021 · 2 comments · Fixed by #12
Closed

Converting villagers in a minecart spawns zombie outside the minecart #10

Kasama opened this issue Apr 10, 2021 · 2 comments · Fixed by #12

Comments

@Kasama
Copy link
Contributor

Kasama commented Apr 10, 2021 •
edited
Loading

In vanilla, villagers in minecarts/boats that get killed by zombies are converted to zombie villagers that are also in the minecart/boat.

That behavior is not mirrored by this plugin.

Villager in minecart getting attacked:
2021-04-10_03 50 44

Free zombie villager after getting converted:
2021-04-10_03 50 50
@Kasama
Copy link
Contributor Author

Kasama commented Apr 10, 2021

a possible solution would be to check if tVillager.isInsideVehicle and if so, Entity vehicle = tVillager.getVehicle and vehicle.addPassenger(zVillager) after removing the old villager from the vehicle.

I don't have the means to implement and test it right now, but by looking at the decompiled source for minecraft, it does something similar.

@Kasama
Copy link
Contributor Author

Kasama commented Apr 10, 2021

Fixed in #11

@Kasama Kasama mentioned this issue Apr 10, 2021
Closed
Kasama added a commit to Kasama/VillagerSaver that referenced this issue Apr 10, 2021
@Kasama
Fix MarioFinale#10 for baby villagers
fa34a38
@Kasama Kasama mentioned this issue Apr 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Kasama