Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for riscv64 #114

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Fix test for riscv64 #114

merged 1 commit into from
Oct 6, 2024

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Oct 5, 2024

Fixes #113

@LTLA
Copy link
Collaborator

LTLA commented Oct 6, 2024

@jonathangriffiths I think this looks fine, the mac failure doesn't seem relevant here.

@jonathangriffiths
Copy link
Collaborator

Thanks for the PR and for checking it over Aaron. Your expertise has saved me a lot of time in the research I'd have had to follow up with.

@jonathangriffiths jonathangriffiths merged commit a5d1cb5 into MarioniLab:devel Oct 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

riscv64 test Failure ('test-hashing.R:244:9'): edge cases are handled correctly with combinatorial barcodes
3 participants
@mr-c @LTLA @jonathangriffiths