-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix device class in some entities #17
Conversation
@Mariusthvdb, |
thank you, and yes, can confirm no more history on battery device_class: thanks @elchininet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fixed, no more history displayed, thank you
thx for the merge, much appreciated! |
@Mariusthvdb, |
on Mac here, thx |
@elchininet |
Hi @Mariusthvdb, |
check please, I've unprotected it |
Hey @Mariusthvdb, |
Yes I believe so |
Done, you can put the protection again. |
Thank you very much ! |
In some entities, like
battery
ones, theoriginal_device_class
property in the more-info___entry
property is not ready when the dialog opens. This was provoking that these entitites were ignored when tried to filter them using their device class.This pull request reads the
original_device_class
property with a promise, making sure that it is resolved when it is properly retrieved or its value isnull
.Closes: #13