Merge branch 'string_split' of https://github.com/MarkMpn/Sql4Cds int…

…o string_split
MarkMpn · Jul 25, 2024 · b2e246f · b2e246f
2 parents da02945 + a385447
commit b2e246f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/MarkMpn.Sql4Cds.Engine.Tests/ExecutionPlanTests.cs b/MarkMpn.Sql4Cds.Engine.Tests/ExecutionPlanTests.cs
@@ -779,7 +779,7 @@ public void GroupByDatePart()
             AssertFetchXml(aggregateFetch, @"
                 <fetch aggregate='true'>
                     <entity name='account'>
-                        <attribute name='createdon' groupby='true' alias='createdon_month' dategrouping='month' />
+                        <attribute name='createdon' groupby='true' alias='createdon_month' dategrouping='month' usertimezone='true' />
                         <attribute name='accountid' aggregate='count' alias='count' />
                         <order alias='createdon_month' />
                     </entity>
@@ -791,7 +791,7 @@ public void GroupByDatePart()
             AssertFetchXml(partitionFetch, @"
                 <fetch aggregate='true'>
                     <entity name='account'>
-                        <attribute name='createdon' groupby='true' alias='createdon_month' dategrouping='month' />
+                        <attribute name='createdon' groupby='true' alias='createdon_month' dategrouping='month' usertimezone='true' />
                         <attribute name='accountid' aggregate='count' alias='count' />
                         <order alias='createdon_month' />
                     </entity>
@@ -844,9 +844,9 @@ GROUP BY
             AssertFetchXml(aggregateFetch, @"
                 <fetch aggregate='true'>
                     <entity name='account'>
-                        <attribute name='createdon' groupby='true' alias='createdon_year' dategrouping='year' />
-                        <attribute name='createdon' groupby='true' alias='createdon_month' dategrouping='month' />
-                        <attribute name='createdon' groupby='true' alias='createdon_day' dategrouping='day' />
+                        <attribute name='createdon' groupby='true' alias='createdon_year' dategrouping='year' usertimezone='true' />
+                        <attribute name='createdon' groupby='true' alias='createdon_month' dategrouping='month' usertimezone='true' />
+                        <attribute name='createdon' groupby='true' alias='createdon_day' dategrouping='day' usertimezone='true' />
                         <attribute name='accountid' aggregate='count' alias='count' />
                         <order alias='createdon_year' />
                         <order alias='createdon_month' />
@@ -862,9 +862,9 @@ GROUP BY
             AssertFetchXml(partitionFetch, @"
                 <fetch aggregate='true'>
                     <entity name='account'>
-                        <attribute name='createdon' groupby='true' alias='createdon_year' dategrouping='year' />
-                        <attribute name='createdon' groupby='true' alias='createdon_month' dategrouping='month' />
-                        <attribute name='createdon' groupby='true' alias='createdon_day' dategrouping='day' />
+                        <attribute name='createdon' groupby='true' alias='createdon_year' dategrouping='year' usertimezone='true' />
+                        <attribute name='createdon' groupby='true' alias='createdon_month' dategrouping='month' usertimezone='true' />
+                        <attribute name='createdon' groupby='true' alias='createdon_day' dategrouping='day' usertimezone='true' />
                         <attribute name='accountid' aggregate='count' alias='count' />
                         <order alias='createdon_year' />
                         <order alias='createdon_month' />

diff --git a/MarkMpn.Sql4Cds.Engine/ExecutionPlan/HashMatchAggregateNode.cs b/MarkMpn.Sql4Cds.Engine/ExecutionPlan/HashMatchAggregateNode.cs
@@ -266,13 +266,6 @@ Source is FetchXmlScan fetch &&
                             canUseFetchXmlAggregate = false;
                             break;
                         }
-
-                        // FetchXML dategrouping always uses local timezone. If we're using UTC we can't use it
-                        if (!context.Options.UseLocalTimeZone)
-                        {
-                            canUseFetchXmlAggregate = false;
-                            break;
-                        }
                     }
                 }
 
@@ -411,6 +404,8 @@ Source is FetchXmlScan fetch &&
                         {
                             attribute.dategrouping = dateGrouping.Value;
                             attribute.dategroupingSpecified = true;
+                            attribute.usertimezone = context.Options.UseLocalTimeZone ? FetchBoolType.@true : FetchBoolType.@false;
+                            attribute.usertimezoneSpecified = true;
                         }
                         else if (grouping.GetType(expressionCompilationContext, out _) == typeof(SqlDateTime))
                         {