Add index api for monitoring if Gunicorn is down #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donny-wong
changed the title
donny-wong
changed the title
pretendWhale
approved these changes
Sep 23, 2024
client/autotest_client/__init__.py
Outdated
| @@ -319,3 +319,8 @@ def cancel_tests(settings_id, **_kw): | |||
| for id_, job in zip(test_ids, _get_jobs(test_ids, settings_id)): | |||
| result[id_] = job if job is None else job.cancel() | |||
| return jsonify(success=True) | |||
|
|
|||
|
|
|||
| @app.route("/index", methods=["GET"]) | |||
There was a problem hiding this comment.
call this route status (and make naming changes throughout)
| return client.get("/index") | ||
|
|
||
| def test_index(self, response): | ||
| assert response.status_code == 200 |
There was a problem hiding this comment.
this is good, but also test the JSON contents of the response
david-yz-liu
approved these changes
Sep 24, 2024
pretendWhale
pushed a commit
to pretendWhale/markus-autotesting
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We want to have notification when Gunicorn is down/hanging for autotesters. Created an API route,
/index, that will be called continually to see if there is a HTTP Status 200 response.