Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add summary feature #37

Merged
merged 9 commits into from
Jan 22, 2024
Merged

add summary feature #37

merged 9 commits into from
Jan 22, 2024

Conversation

vkehfdl1
Copy link
Contributor

close #33

node summary

=> The result of each module & module params.

node line summary

=> The best module name & module params from each node.

trial summary

=> The best module name & module params from each node and node line.

@Eastsidegunn
Copy link
Contributor

there is no optional word better than summary?
I try to think about it, nothing comes to mind.

Copy link
Contributor

@bwook00 bwook00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Eastsidegunn Eastsidegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to watch it hard for better code. However, I'm so tired that I don't know if I watched it as well as my normal performance. Anyway, LGTM

@vkehfdl1 vkehfdl1 merged commit 0d7ed98 into main Jan 22, 2024
3 checks passed
@vkehfdl1 vkehfdl1 deleted the Feature/#33 branch January 22, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add summary recording feature
3 participants