Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change add_file_name language notation #717

Merged
merged 3 commits into from
Sep 16, 2024
Merged

change add_file_name language notation #717

merged 3 commits into from
Sep 16, 2024

Conversation

bwook00
Copy link
Contributor

@bwook00 bwook00 commented Sep 16, 2024

close #715

vkehfdl1
vkehfdl1 requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change this

else:
		raise ValueError(
			f"Unsupported file_name_language: {file_name_language}. Choose from 'english' or 'korean'."
		)

Error must be notice that user have to use 'en' or 'ko'

vkehfdl1
vkehfdl1 previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkehfdl1 vkehfdl1 enabled auto-merge (squash) September 16, 2024 12:32
vkehfdl1
vkehfdl1 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkehfdl1 vkehfdl1 merged commit 8b64f75 into main Sep 16, 2024
3 checks passed
@vkehfdl1 vkehfdl1 deleted the Feature/#715 branch September 16, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkehfdl1 vkehfdl1 vkehfdl1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chunk] change add_file_name language notation
2 participants
@bwook00 @vkehfdl1