Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenVINO Reranker module #808

Merged
merged 8 commits into from
Oct 6, 2024
Merged

Add OpenVINO Reranker module #808

merged 8 commits into from
Oct 6, 2024

Conversation

bwook00
Copy link
Contributor

@bwook00 bwook00 commented Oct 6, 2024

close #790

  • Add del func at MonoT5 Class

@bwook00 bwook00 requested a review from vkehfdl1 October 6, 2024 08:14
vkehfdl1
vkehfdl1 requested changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure this passed all tests right?

autorag/nodes/passagereranker/monot5.py Outdated Show resolved Hide resolved
autorag/nodes/passagereranker/openvino.py Outdated Show resolved Hide resolved
autorag/nodes/passagereranker/openvino.py Outdated Show resolved Hide resolved
@vkehfdl1 vkehfdl1 enabled auto-merge (squash) October 6, 2024 09:29
@bwook00
Copy link
Contributor Author

bwook00 commented Oct 6, 2024 •
edited
Loading

The test passed perfectly (But it's still a little slow)

@vkehfdl1 vkehfdl1 self-requested a review October 6, 2024 14:58
vkehfdl1
vkehfdl1 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Natural it is slow on your local mac

@vkehfdl1 vkehfdl1 merged commit 84c23a3 into main Oct 6, 2024
3 checks passed
@vkehfdl1 vkehfdl1 deleted the Feature/#790 branch October 6, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkehfdl1 vkehfdl1 vkehfdl1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] New OpenVINO Rerank module
2 participants
@bwook00 @vkehfdl1