-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add External VectorDB Connections #872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection to Chroma vector store instance. (#871) * add Chroma wrapper for vectorstore compatibility * Make my own Chroma class * refactor get_id_scores * replace chroma to VectorStore instance with async * use vector store embedding at vectordb module * optimize imports --------- Co-authored-by: jeffrey <vkefhdl1@gmail.com>
…ordb module. (#874) * make load_yaml_config for easier retrieve config yaml file * load vectordb instance from config YAML file * load vectordb from YAML in the vectordb module * fixed wrong annotation --------- Co-authored-by: jeffrey <vkefhdl1@gmail.com>
* add filter from corpus data and filter from retrieval_gt for optional ingest * make Evaluator with external vectordb working. --------- Co-authored-by: jeffrey <vkefhdl1@gmail.com>
Co-authored-by: jeffrey <vkefhdl1@gmail.com>
* extract vectordb and save it to extracted yaml as also * add delete collection method for milvus * edit hybrid testing for new vectordb * optimize imports at test_hybrid_cc.py --------- Co-authored-by: jeffrey <vkefhdl1@gmail.com>
* add vector db documentations (milvus and chroma) * change documentation file for vectordb * Fix all sample config YAML file to use vectordb --------- Co-authored-by: jeffrey <vkefhdl1@gmail.com>
bwook00
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.