Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/docker deploy push #887

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Feature/docker deploy push #887

merged 2 commits into from
Oct 25, 2024

Conversation

hongsw
Copy link
Collaborator

@hongsw hongsw commented Oct 25, 2024 •
edited
Loading

  • build: add Dockerfile for base image with common dependencies and stages for different functionalities

@hongsw hongsw requested a review from vkehfdl1 October 25, 2024 12:30
vkehfdl1
vkehfdl1 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkehfdl1 vkehfdl1 merged commit d6dfe31 into main Oct 25, 2024
3 checks passed
@vkehfdl1 vkehfdl1 deleted the Feature/docker-deploy-push branch October 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkehfdl1 vkehfdl1 vkehfdl1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongsw @vkehfdl1