Make Hybrid Retrieval RRF module and edit run.py for it #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
February 1, 2024 09:16
…s from already done results
# Conflicts: # autorag/support.py
# Conflicts: # autorag/evaluator.py # autorag/nodes/retrieval/run.py # tests/autorag/nodes/retrieval/test_run_retrieval_node.py
# Conflicts: # autorag/nodes/retrieval/run.py # tests/autorag/nodes/retrieval/test_run_retrieval_node.py # tests/autorag/utils/test_util.py
Eastsidegunn
reviewed
Feb 1, 2024
|
have a nice night |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #82
1. Add Hybrid RRF module. Reciprocal Rank fusion the results of retrievals. It uses ids and scores from `already-done` results.To use Hybrid module, you need to do 2 things at your yaml file.
First, you need to set more than 2 retrieval modules.
Second, set names of your module as
target_modulesat yaml file as tuple.Add tuple function at yaml loader.
Initially, tuple does not support at yaml file.
But, there was no way to pass multiple value parameters at module functions in AutoRAG, due to
make_combinationsfunction. It is function that make all combinations inside module params list.So, I make tuple at config yaml file, and turn it to real tuple using
convert_string_to_tuple_in_dictfunction.Now, you can load tuple as single module parameter.
Execution time of hybrid retrieval.
Hybrid Retrieval module in AutoRAG did not
acutallyrun each modules, so it can't get real execution time.So, I extract best module from each target_modules, and get their exectuion time and sum it.
This way, we can properly filter by speed (execution_time) at hybrid retrieval.
Fix error at
make_combinationsat delete duplication.As you see at number 2, tuple occured error at
list(set())for deleting duplication at module params.So, from now, we do not perform duplication delete at unhashable objects like tuple, list, dict..
Most of time, the duplication deletion feature will perform.