Client side certificates

[aculclasure]

At my workplace, I discovered a need to test HTTPS requests against a server requiring client side certificates as described in the 'Advanced Usage' documentation for the Python Requests library (http://docs.python-requests.org/en/master/user/advanced/). This pull request adds:

1. 'Create Client Cert Session' keyword that accepts a client key and client certificate (in PEM format)
2. Updated documentation to describe the new keyword.
3. Updated tests/testcase.txt to include a test for an HTTPS requests requiring client side certificates.

[aculclasure]

Hi,

First, many apologies for the repeated opening/closing of pull requests! I had some errant automation in place that was causing this behavior instead of simply updating my forked repo! Please feel free to let me know if you need any more information from me or need any use cases for this pull request. Thank you!

~ Andrew

[vkosuri]

@bulkan Any comments on this?

[vkosuri]

@bulkan Any suggestions/comments?

[tvainika]

There seems to be some extra effort to still support py2.6 here. Official Python 2.6 is already past of its lifetime since 2013-10-29 ( https://docs.python.org/devguide/#status-of-python-branches ). The next version of Pip no longer supports 2.6 (already merged pypa/pip#4343 ) and underlying Requests library is also dropping support for 2.6 (discussion psf/requests#3928 ).

So instead of just flagging py2.6 travis tests as non-critical, what about just dropping those?

[aculclasure]

Hi @tvainika ,

Is dropping the py2.6 travis tests something that would be done on the Github side or is it something that I can do within my forked repo?

Andrew

[tvainika]

In this PR there is a modification in .travis.yml to change 2.6 tests as non-critical. IMHO it would make sense to just drop 2.6 env totally from travis configs. But I don't know if this PR was actually correct forum for that discussion anyway.

[vkosuri]

I think i agree with @tvainika comments, @elskohder could you please drop python 2.6 from travis?

[vkosuri]

Due to network issue some tests are failed, i restarted the build now it should pass.

[szet]

Hi, I need this functionality as well but it's still not merged with the main branch right? I'm still a bit new to git so can anyone teach me how I can merge this with my local copy of Requests Library?

[vkosuri]

This reference will help you https://stackoverflow.com/questions/21651185/git-merge-a-remote-branch-locally

[szet]

Thanks! This new keyword helped me a lot in my tests, hopefully it gets merged with the main branch soon :)

[sudhagarc]

This keyword is really helpful and helped me as well. Could we get this merged into main branch, please? Thanks.

[vkosuri]

LGTM, @elskohder Greak work, @bulkan any comments/suggestions? can i merge this into master?

[surfgirl]

@bulkan Hi, we are trying to implement Request Library and one of the test cases (Get HTTPS & Verify Cert with a CA bundle) to our test suite, and we keep on getting fail with the comment:
"[ ERROR ] Certificate did not match expected hostname: ...". Do you have any idea what can be a problem>

Thank you,

[oleduc]

@surfgirl The certificate served by the server you are querying does not match the domain you are using to access it. The server might be serving a certificate for domainA.xyz but you are accessing it with domainB.xyz. It could also be that you are accessing it using a sub-domain not covered by your certificate.

[surfgirl]

@oleduc I am not sure if this is a case, because when we perform this test in SOAP UI it works...

[bulkan]

@surfgirl can you share your failing test case ?

[surfgirl]

@bulkan

Create UVP session
    [Tags]  Keyword that just creates session, it is important for TC to even run
                    ...  ${SESSION NAME} is alias for session which will be used to call it.
    Create session  ${SESSION NAME}  ${SESSION ADRESS}  verify=${CURDIR}${/}b2csso.pem
    ${resp}=  Get Request  UserPassport  /get
    Should Be Equal As Strings  ${resp.status_code}  200`

${SESSION ADRESS}  https://sodp-uvp-4t.skoda-auto.com/uvp
${SESSION NAME}  UserPassport

[surfgirl]

@bulkan also what is important we originally had p12 certificate and it was converted to pem, do you think that might be a case?