Skip to content

Commit

Permalink
misc. cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
thinkyhead committed Mar 3, 2021
1 parent 369ffe5 commit fd270dd
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
6 changes: 3 additions & 3 deletions Marlin/src/HAL/STM32/tft/tft_spi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,12 @@ void TFT_SPI::Transmit(uint16_t Data) {
while ((SPIx.Instance->SR & SPI_FLAG_BSY) == SPI_FLAG_BSY) {}

if (TFT_MISO_PIN != TFT_MOSI_PIN)
__HAL_SPI_CLEAR_OVRFLAG(&SPIx); /* Clear overrun flag in 2 Lines communication mode because received is not read */
__HAL_SPI_CLEAR_OVRFLAG(&SPIx); // Clear overrun flag in 2 Lines communication mode because received is not read
}

void TFT_SPI::TransmitDMA(uint32_t MemoryIncrease, uint16_t *Data, uint16_t Count) {
// Wait last dma finish, to start another
while(isBusy()) { }
while (isBusy()) { /* nada */ }

DMAtx.Init.MemInc = MemoryIncrease;
HAL_DMA_Init(&DMAtx);
Expand All @@ -225,7 +225,7 @@ void TFT_SPI::TransmitDMA(uint32_t MemoryIncrease, uint16_t *Data, uint16_t Coun
HAL_DMA_Start(&DMAtx, (uint32_t)Data, (uint32_t)&(SPIx.Instance->DR), Count);
__HAL_SPI_ENABLE(&SPIx);

SET_BIT(SPIx.Instance->CR2, SPI_CR2_TXDMAEN); /* Enable Tx DMA Request */
SET_BIT(SPIx.Instance->CR2, SPI_CR2_TXDMAEN); // Enable Tx DMA Request

HAL_DMA_PollForTransfer(&DMAtx, HAL_DMA_FULL_TRANSFER, HAL_MAX_DELAY);
Abort();
Expand Down
4 changes: 2 additions & 2 deletions Marlin/src/lcd/extui/lib/anycubic_chiron/chiron_tft.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ namespace Anycubic {

bool ChironTFT::ReadTFTCommand() {
bool command_ready = false;
while(TFTSer.available() > 0 && command_len < MAX_CMND_LEN) {
while (TFTSer.available() > 0 && command_len < MAX_CMND_LEN) {
panel_command[command_len] = TFTSer.read();
if (panel_command[command_len] == '\n') {
command_ready = true;
Expand Down Expand Up @@ -338,7 +338,7 @@ namespace Anycubic {

int8_t ChironTFT::Findcmndpos(const char * buff, char q) {
int8_t pos = 0;
do { if (buff[pos] == q) return pos; } while(++pos < MAX_CMND_LEN);
do { if (buff[pos] == q) return pos; } while (++pos < MAX_CMND_LEN);
return -1;
}

Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/lcd/extui/lib/dgus/mks/DGUSScreenHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ void DGUSScreenHandler::DGUSLCD_SendTMCStepValue(DGUS_VP_Variable &var) {

void DGUSScreenHandler::SDPrintingFinished() {
if (DGUSAutoTurnOff) {
while(!queue.ring_buffer.empty()) queue.advance();
while (!queue.ring_buffer.empty()) queue.advance();
gcode.process_subcommands_now_P(PSTR("M81"));
}
GotoScreen(MKSLCD_SCREEN_PrintDone);
Expand Down
6 changes: 4 additions & 2 deletions Marlin/src/lcd/extui/lib/mks_ui/draw_print_file.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ uint8_t sel_id = 0;
//root2.rewind();
//SERIAL_ECHOLN(list_file.curDirPath);

if (curDirLever != 0) card.cd(list_file.curDirPath);
else card.cdroot(); // while(card.cdup());
if (curDirLever != 0)
card.cd(list_file.curDirPath);
else
card.cdroot();

const uint16_t fileCnt = card.get_num_Files();

Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/lcd/menu/menu_ubl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ void ubl_map_screen() {
if (position_is_reachable(xy)) break; // Found a valid point
ui.encoderPosition += step_dir; // Test the next point
#endif
} while(ENABLED(IS_KINEMATIC));
} while (ENABLED(IS_KINEMATIC));

// Determine number of points to edit
#if IS_KINEMATIC
Expand Down

0 comments on commit fd270dd

Please sign in to comment.