Ender 6 config does not compile #21274
Comments
|
The issue is now patched! Thanks for the report. |
|
Thanks thinkyhead! |
|
patched means that the issue has been fixed in bugfix. Download latest version and try again. |
|
Hi together, thanks for fixing the issue with include path fpr powerloss.h. Log Output |
|
looks lik one include path was still wrong. BUT now I get the following errors: Log Output |
|
I can confirm, Current bugfix and bugfix Ender 6 Example Config files will not compile. |
|
The first sprintf_P bug is easy, in Marlin/src/lcd/extui/lib/dgus/DGUSScreenHandler.cpp find sprintf_P(buf, PSTR("M303 E-1 C5 S70 U1")); The second filelist bug is in Marlin/src/lcd/extui/lib/dgus/origin/DGUSScreenHandler.cpp the last bug however has me stumped. Looks like incomplete code There is no screen of this name in dgus/origin this screen is from dgus/mks and I cant see an equivalent. |
|
Thank You
I will see if I find the time to get into the Marlin Code Univers to see if I can help.... But I might need help to better understand the Marlin Code structure. Would you be willing to help me if I have questions? Or is there a great place to go to understand the overall code better?
Thanks for the other tips I will try it and provide feedback
Holen Sie sich Outlook für iOS<https://aka.ms/o0ukef>
…________________________________
Von: ellensp <notifications@github.com>
Gesendet: Sunday, March 7, 2021 11:56:29 AM
An: MarlinFirmware/Marlin <Marlin@noreply.github.com>
Cc: Majestix1970 <eike.recker@outlook.de>; Mention <mention@noreply.github.com>
Betreff: Re: [MarlinFirmware/Marlin] Ender 6 config does not compile (#21274)
The first sprintf_P bug is easy, in Marlin/src/lcd/extui/lib/dgus/DGUSScreenHandler.cpp
find sprintf_P(buf, PSTR("M303 E-1 C5 S70 U1"));
replace with sprintf_P(buf, PSTR("M303 E-1 C5 S70 U1"), ExtUI::heater_t::BED);
The second filelist bug is in Marlin/src/lcd/extui/lib/dgus/origin/DGUSScreenHandler.cpp
just add static ExtUI::FileList filelist; after #if ENABLED(SDSUPPORT)
the last bug however has me stumped. Looks like incomplete code
It is in Marlin/src/lcd/extui/lib/dgus/origin/DGUSScreenHandler.cpp
the line is GotoScreen(MKSLCD_SCREEN_PAUSE);
There is no screen of this name in dgus/origin this screen is from dgus/mks and I cant see an equivalent.
You can comment out this line and it compiles, but that leaves a broken SD_ResumePauseAbort menu.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMarlinFirmware%2FMarlin%2Fissues%2F21274%23issuecomment-792257237&data=04%7C01%7C%7Ce933e13f46d049aaa76708d8e157a9c7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637507113904667996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=zNrpYZtLVToBMtvmp7GCFJmGH%2BkxvG7d%2F%2FZnuI6joUA%3D&reserved=0>, or unsubscribe<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIJ2OEYIKGWHPDGFHHE4S5TTCNLV3ANCNFSM4YW3VZVQ&data=04%7C01%7C%7Ce933e13f46d049aaa76708d8e157a9c7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637507113904667996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ELj4WHoun6iAJC1w98riIVywY%2BP1IasMV%2F3WlDTWmp4%3D&reserved=0>.
|
|
Hi ellensp, Log Output |
|
Sorry ellensp! My mistake Now I can look into this. Thanks again |
|
I did the following.... Now it compiles successfully! Is that a valid fix? Where can I find information on how this screen handling/setup is structured? Thanks for your help |
|
Also it looks like the macro defind in pgmspace.h:29:59: Any advice? here the warning : Log Output |
|
sorry for the type... "throws" not "thoughts" ;-) |
|
sprintf is expacting a parameter e.g %d in the format string. Thats why it throws this warning... If I do so the compiler is happy and no warnings any more. |
|
Hi, any idea what this could be..... Log Output |
|
Hm..... just figured out that the whole definition of the funktion [https://gitlab.d-net.ovh/dusakus/marlin-ferk/-/blob/5f27f7de47191c5cd2a6f4c2f0b65748ef13c268/Marlin/src/lcd/extensible_ui/lib/dgus/DGUSDisplay.h] it looks not complete to me. Any idea whats wrong here? /// Send a float value to the display.
/// Display will get a 4-byte integer scaled to the number of digits:
/// Tell the display the number of digits and it cheats by displaying a dot between...
template<unsigned int decimals>
static void DGUSLCD_SendFloatAsLongValueToDisplay(DGUS_VP_Variable &var) {
if (var.memadr) {
float f = *(float *)var.memadr;
f *= cpow(10, decimals);
union { long l; char lb[4]; } endian;
char tmp[4];
endian.l = f;
tmp[0] = endian.lb[3];
tmp[1] = endian.lb[2];
tmp[2] = endian.lb[1];
tmp[3] = endian.lb[0];
dgusdisplay.WriteVariable(var.VP, tmp, 4);
}
} |
|
just a short update.... did compile, but after flashing firmware, the display remains black..... any help is more than welcome... |
|
Hi out there.... |
|
tried to compile firmware for ender 6 tonight and still fails |
|
Sorry, we are needing fixes from @makerbase-mks and maybe @solawc …. The ExtUI code for DGUS displays was never very stable to begin with, and it was "approved" by the submitters apparently before really being tested. |
|
Is there config files available for the 12864 LCD Display (Ender 3 screen) instead. Or is it easy to change it in the current files and will it then compile? |
|
@msedlak77 In theory all you need to do that is disable DGUS_LCD_UI_ORIGIN and enable the new type of screen CR10_STOCKDISPLAY |
Hi, I'm sorry for the problem. Colleagues, I also have doubts. If dgus is turned DGUS_LCD_UI_MKS, the compilation error path should not appear in /dgus/origin/dgusscreenhandler.cpp, but should be in /dgus/mks/dgusscreenhandler.cpp, because it has been separated and independent. @Majestix1970 |
|
Any traction on this issue? still can't compile Marlin using Ender6 config. Thanks, |
|
no unfortunately not.... I> started to dig into this issue and was sofar able to understand and already change the screen configuration of the DGUS II Ender6 display. What needs to be done now is to understand how the Marlin screen handler is programmed (I did not do this before...) Maybe someone could help me explain how to programm your own screen handler in Marlin. The DGUS II DIsplay ist completely different in working as all the other displays.... Any help is appreceated! I do not have to time currently to learn it by my self from scratch.
|
|
Has anyone been able to actually flash to the ender 6? i can compile the bin but every time try to flash it just stays on loading screen... |
|
I tried to cheat by changing the mkslcd_screen_pause with a proper one from DGUSDisplayDef.h (DGUSLCD_SCREEN_WAITING to be exact) just to make it compile at least and work until i hit the pause in screen. It compiled. But it just stucks during flashing at the opening screen with the loading bar at %0. With the latest config file, the Marlin tries to use DGUS lcd in the extui folder but the problem is, as stated above, there is no screen defined for pause. But i've no idea why it doesn't flash even though another screen is set to be pop up when pressed pause. |
|
Same issue here. tried both the regular and bugfix versions and get the following error: In file included from C:\Users\ssass.platformio\packages\framework-arduinoststm32-maple\STM32F1\cores\maple/WString.h:29:0, |
|
After PR #22464 was added to fix this LCD type on the ender 5 plus |
|
If you really want to use te maple env, apply this diff diff --git a/Marlin/src/lcd/extui/dgus/DGUSScreenHandler.cpp b/Marlin/src/lcd/extui/dgus/DGUSScreenHandler.cpp
index 57ecc4bb65..5b91b7a880 100644
--- a/Marlin/src/lcd/extui/dgus/DGUSScreenHandler.cpp
+++ b/Marlin/src/lcd/extui/dgus/DGUSScreenHandler.cpp
@@ -559,7 +559,7 @@ void DGUSScreenHandler::HandleStepPerMMExtruderChanged(DGUS_VP_Variable &var, vo
#endif
#if ENABLED(PIDTEMPBED)
case VP_PID_AUTOTUNE_BED:
- sprintf_P(buf, PSTR("M303 E-1 C5 S70 U1"));
+ sprintf_P(buf, PSTR("M303 E%d C5 S70 U1"),-1);
break;
#endif
} |
|
@thinkyhead do we want to patch for maple env or should we just start removing maple env's as they fail? |
|
Are you saying that Maple platforms are still being updated by "Maple, Inc." and breaking our builds? |
|
@thinkyhead no, that there is a bug in maple env. that marlin triggers In this case sprintf_P without a variable will not compile |
|
Are we confident that STM32 now has everything covered and that there are no boards or situations that need Maple to work best? |
|
not fully for all boards, and I don't recommend removing all maple in one go at all. For now I am just talking about potentially removing maple build option from the pins.h for this one board. |
|
It's fine if all |
|
Hi all! Can someone of you explain/tell me please where in the Marlin code / files I find the source code to map the DGUS screen Id and variable IDs to the normal Marlin commands. so far I maneged to change and compile the DGUS original Ender 6 screens. Now I need to understand how the marlin code die read/send DGUS screen command to from/to the display. If I understood that, I could provide a complete tutorial to change/udapt and compile the DGSU screen for the Ender6 and provide a correct Marlin display driver. Thanks |
|
I've just ran the compile using the Ender 6 configs again, but I still
get the same sort of errors? Has anyone successfully compiled Ender 6
firmware using the latest config?
|
|
@sassysander you need to use current bugfix or current 2.0.x (from today) and you probably should delete your Marlin/.pio directory |
|
@ellensp would you perhaps be available to help me debug this perhaps? I'd be happy to make a donation, or buy you a coffee? |
|
@sassysander come to the discord https://discord.gg/n5NJ59y and post in general "Looking for ellensp" ill start a DM with you. But be quick its really late here |
|
@ellensp same here, I'm also about to call it a night! Can I propose a different approach perhaps? I have a document prepared with some questions etc. illustrated with a few videos, can I forward that to you so you can have a look? Perhaps email is better suited for this? FYI, I can be reached at github(at)sassiness(dot)nl. |
|
Will think about it tomorrow then |
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi
thank you for creating an Ender 6 setup....
Unfortunately I can not get it compiled with VS Code 1.54.1 and PlatformIO Core 5.1.0
and latest Marlin 2.0-bugfix nighly build (06 March 2021) and your original configuration.h and Configuration_adv.h (No changes at all)
I would appriciate your help.
Best regards
Eike
I get the following error:
Complete Build Output, enjoy!
Originally posted by @Majestix1970 in MarlinFirmware/Configurations#375 (comment)
The text was updated successfully, but these errors were encountered: