Attempt to resolve #1568 and add basic escape character support #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "G1 X1 ; test" was not executing "G1 X1" due to never leaving comment mode.
* "M117 Hello \;)" printed "Hello \" to the display due to not replacing serial_char properly.
Tested with the following commands:
* M117 Hello ; test => displays "Hello" on display, ignores "test"
* G1 X1 ; foo => moves 1mm in X, ignores "foo"
* ; test => completely ignored, not even acknowledged
* M117 Hello \;) => displays "Hello ;)" on display
* M117 Hello \\;) => displays "Hello \" on display, ignores ")"
In-line comments and escaping fixed by foosel
|
Tested with the following commands:
Also |
|
Very good catch & fix. This will be merged very soon, after I give it a test run also! |
thinkyhead
added a commit
that referenced
this pull request
Mar 6, 2015
Fixes gCode handling of comments and escaped characters
joaquin-herrero
pushed a commit
to bq/Marlin
that referenced
this pull request
Nov 27, 2015
…e character support MarlinFirmware#1570 from upstream Marlin. Related commits: '99fb1bc' by C-o-r-E '63b62d8' by foosel 'ba27f90' by C-o-r-E
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #1568 regarding use of a colon. I've also modified the routine to allow for escaped characters.
Extra testing apreciated ;-]