Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build script for upcoming PIO 4.4 #19034

Conversation

rhapsodyv
Copy link
Sponsor Member

@rhapsodyv rhapsodyv commented Aug 15, 2020

Description

CI are using PIO 4.4 and is breaking because a core class was removed. This PR updates the dependency script to work with both PIO versions.

I think this PR should be part of the upcoming 2.0.6.1, as PIO could release their new version anytime.

Benefits

Fixes CI
Compatibility with PIO >= 4.4 and < 4.4

Related Issues

#18699

@thinkyhead
Copy link
Member

How did you learn about this change? It looks like there are some other fails as well.

@rhapsodyv
Copy link
Sponsor Member Author

How did you learn about this change? It looks like there are some other fails as well.

Ivan told us that PIO was changing their package spec parser (in the comments of #18699). This PR do what he told us to do: use the new package spec parser. And keep compatibility with the old PIO too.

I checked, and now the CI is failing because missing packages in PIO registry... Now I don't know if is a pio bug, or if is because Ivan is releasing it right now, or if the package is missing...

@rhapsodyv
Copy link
Sponsor Member Author

Error: Could not find a package with 'framework-arduino-lpc176x @ >=0.2.2' requirements for your system 'linux_x86_64'

@rhapsodyv
Copy link
Sponsor Member Author

I think we need take a break of using pio dev in CI, and trying to figure out what will break in PIO 4.4.
I just don’t know if we must do it right now. Ivan just pushed the changes to PIO repo. Seems to early and he might be working in the update right now.

@thinkyhead
Copy link
Member

It seems that other things are generally broken. When I try to do the native sim build with PIO Core 4.3.4 I get all kinds of new errors about missing standard headers. And if I try to build the native sim with 4.4.0a8 with the changes in this PR I get a weird error from pioplatform.py….

@rhapsodyv
Copy link
Sponsor Member Author

Seem he pushed the new PIO to dev branch, but not updated the PIO registry yet. Or we are just in the middle of a PIO big release...

platformio/platformio-core@04694b4

@thinkyhead
Copy link
Member

Until that is sorted, I will revert back to pio/master for CI.

@thinkyhead thinkyhead merged commit bb64aa7 into MarlinFirmware:bugfix-2.0.x Aug 16, 2020
@ivankravets
Copy link
Contributor

Error: Could not find a package with 'framework-arduino-lpc176x @ >=0.2.2' requirements for your system 'linux_x86_64'

Sorry, we upload this package to the registry. Now, everything should work.

  1. Please switch back to develop branch. We don't plan to make any changes in PIO Core 4.4 internal API. We are going to release it at the ned of month.
  2. How to apply this PR to 2.0.x branch?

Thanks!

den-kozlov pushed a commit to den-kozlov/Marlin_for_Hypercube that referenced this pull request Aug 18, 2020
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Aug 20, 2020
albertogg pushed a commit to albertogg/Marlin that referenced this pull request Aug 31, 2020
@rhapsodyv rhapsodyv deleted the remove-platformio.managers.package branch October 25, 2020 00:27
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants