Changes to fix issue with UBL and ADC Keypad and PAUSE_BEFORE_DEPLOY_STOW #23587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clear keypad_button reset to 0 option
Add quick_feedback(true) to chirp and keypad_buttons = 0
|
Thanks for your contribution! Unfortunately we can't accept PRs directed at release branches. We make patches to the bugfix branches and only later do we push them out as releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for UBL G29 P1 with PAUSE_BEFORE_DEPLOY_STOW. Marlin will jump right to Mesh only partially populated in UBL_G29.cpp and will hand up in while loop without these changes. See issue #23514 for more info. This does not fix the issue with ADC keypress while building mesh which also hangs in wait_for_release() loop. That will require more work.
ADC Keypad with UBL Enabled and PAUSE_BEFORE_DEPLOY_STOW Enabled.
Fixes operation with UBL and ADC Keypad and AUSE_BEFORE_DEPLOY_STOW
Configurations
Related Issues