introduce get_distance function #25370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerAndere1
force-pushed
the
get_distance
branch
5 times, most recently
from
ef39f9c
to
68b5c26
Compare
DerAndere1
force-pushed
the
get_distance
branch
from
68b5c26
to
b723565
Compare
thinkyhead
force-pushed
the
get_distance
branch
3 times, most recently
from
d5c7480
to
cf0933a
Compare
thinkyhead
force-pushed
the
get_distance
branch
from
cf0933a
to
183aab0
Compare
DerAndere1
force-pushed
the
get_distance
branch
from
f565c98
to
d19302b
Compare
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Feb 22, 2023
mikezs
added a commit
to mikezs/Marlin
that referenced
this pull request
Feb 27, 2023
* bugfix-2.1.x: (113 commits) [cron] Bump distribution date (2023-02-27) ✨ LCD_BACKLIGHT_TIMEOUT for Neopixel LCD (MarlinFirmware#25438) 🔨 Fix env STM32G0B1RE_btt, add …_manta_btt (MarlinFirmware#25431) 🩹 Native types for RTS overloads (MarlinFirmware#25440) 📝 Link to archived RA Control Panel page (MarlinFirmware#25424) 📝 New URL for IA_CREALITY DWIN files (MarlinFirmware#25423) [cron] Bump distribution date (2023-02-24) 📝 Update DISABLE_INACTIVE_* comment 🎨 Use LIMIT macro ⚡️ Reduce edit_screen code size (MarlinFirmware#25420) ♻️ Stepper options refactor (MarlinFirmware#25422) [cron] Bump distribution date (2023-02-23) 🔧 Fix Einsy Rambo TMC driver check 🔨 Fix marlin_custom.* without lib_deps [cron] Bump distribution date (2023-02-22) 🐛 Fix AVR maths used by Stepper (MarlinFirmware#25338) 🔨 Encrypt some MKS Robin (MarlinFirmware#25349) 🌐 Update Russian language (MarlinFirmware#25360) 🧑💻 Fix preheat tests (nested macro limit ~256) 🧑💻 Add get_move_distance for rotation/kinematics (MarlinFirmware#25370) ... # Conflicts: # Marlin/Configuration_adv.h
LMBernardo
pushed a commit
to LMBernardo/Marlin
that referenced
this pull request
Mar 19, 2023
thinkyhead
pushed a commit
that referenced
this pull request
Apr 7, 2023
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
Apr 8, 2023
thinkyhead
pushed a commit
that referenced
this pull request
Apr 10, 2023
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
May 16, 2023
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 17, 2023
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split off from #24334. The new get_distance function calculates distance from axis displacements and also updates a flag that is passed by reference as parameter
is_cartesian_move. An alternative solution would be a function that returns a struct that would be defined like this:Requirements
None
Benefits
Makes distance- and feedrate calculation more consistent across features. Prepare kinematic logic for true continuous multi-axis machining.
Configurations
TODO
Related Issues
#23116