Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Followup to ♻️ BTT_SKR_V3_0 => BTT_SKR_3 / 3a6bd69 #27461

Conversation

thisiskeithb
Copy link
Member

Description

Fix improper MB() macro usage from "♻️ BTT_SKR_V3_0 => BTT_SKR_3" / 3a6bd69

Requirements

SKR V3, SKR V3 EZ

Benefits

Renamed motherboard sanity checks will work correctly.

Related Issues

@thisiskeithb
Copy link
Member Author

Also: Why was the SKR V3 renamed?

Now it no longer follows the same naming scheme as the rest of the SKR boards.

@thinkyhead
Copy link
Member

thinkyhead commented Oct 8, 2024

BTT seems to be pretty consistent in referring to the board as the "SKR 3" and not as SKR V3.0; meanwhile, other SKR boards with V1 and V2 are not referred to as SKR 1 or SKR 2 in the materials I reviewed. The board might actually be named "SKR-3 Version 1.0." We can look closer at the silk screen or ask BigTreeTech for clarification if I have misconstrued the way that they refer to this board as other than version 3.0 of the common "SKR" board.

@thisiskeithb
Copy link
Member Author

thisiskeithb commented Oct 8, 2024

BTT seems to be pretty consistent in referring to the board as the "SKR 3" and not as SKR V3.0

They aren't consistent, but we should be.

The back of the SKR V3 has both "SKR 3" and "V3", so I'd prefer we not randomly change the naming scheme for a single board.

I'd prefer we revert the SKR V3 name change or change all SKR boards to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants