api: allow urlencoded path parameters, java client: properly urlencode path parameters #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1419 +/- ##
============================================
- Coverage 79.80% 79.73% -0.08%
- Complexity 916 922 +6
============================================
Files 197 197
Lines 5759 5778 +19
Branches 393 397 +4
============================================
+ Hits 4596 4607 +11
- Misses 744 747 +3
- Partials 419 424 +5
Continue to review full report at Codecov.
|
wslulciuc
reviewed
Jun 17, 2021
clients/java/src/main/java/marquez/client/MarquezWriteOnlyClientImpl.java
Outdated
Show resolved
Hide resolved
wslulciuc
reviewed
Jun 17, 2021
clients/java/src/test/java/marquez/client/MarquezWriteOnlyClientTest.java
Outdated
Show resolved
Hide resolved
wslulciuc
reviewed
Jun 17, 2021
| @@ -89,7 +88,7 @@ public void testCreateRunWithId() { | |||
| RunMeta runMeta = RunMeta.builder().id(id).build(); | |||
| client.createRun("namespaceName", "jobName", runMeta); | |||
| verify(backend, times(1)) | |||
| .post("/api/v1/namespaces/namespaceName/jobs/jobName/runs", runMeta.toJson()); | |||
There was a problem hiding this comment.
what do you think about handling this case also in method?
private URL url(String path) {
There was a problem hiding this comment.
Any idea of something better than
if (baseUrl.toString().endsWith("/") && path.startsWith("/")) {
path = path.substring(1);
} else if (!baseUrl.toString().endsWith("/") && !path.startsWith("/")) {
path = "/" + path;
}
mobuchowski
force-pushed
the
fix-namespace-path-parsing
branch
2 times, most recently
from
623a293
to
3504d08
Compare
mobuchowski
force-pushed
the
fix-namespace-path-parsing
branch
2 times, most recently
from
da0ed70
to
628a0c8
Compare
|
@wslulciuc @OleksandrDvornik can we merge it? |
|
looks good for me |
wslulciuc
reviewed
Jun 22, 2021
wslulciuc
reviewed
Jun 22, 2021
There was a problem hiding this comment.
@mobuchowski, changes look great! I left a comment about reverting some changes related to the paths that are internal. Once reverted, we're good to merge 👍
mobuchowski
force-pushed
the
fix-namespace-path-parsing
branch
5 times, most recently
from
cd72250
to
4e801ae
Compare
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@getindata.com>
mobuchowski
force-pushed
the
fix-namespace-path-parsing
branch
from
4e801ae
to
0af7a69
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use HttpCompliance.RFC7230_LEGACY to allow potentially ambiguous URIs with encoded path segments.
Refactor Marquez Java client to properly urlencode path segments.