Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce limit for list datasets jobs in UI #2018

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

wslulciuc
Copy link
Member

Problem

The current UI default limit to list datasets and jobs is 2000 which can be an expensive query. A more ideal approach would be to introduce paging (see #1711), but for now, let's use a reasonable default 25.

Solution

Reduce limit for list datasets jobs from 2000 to 25.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc requested a review from phixMe June 14, 2022 23:50
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #2018 (33e0d9b) into main (c53f66c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2018   +/-   ##
=========================================
  Coverage     78.89%   78.89%           
  Complexity     1014     1014           
=========================================
  Files           197      197           
  Lines          5548     5548           
  Branches        421      421           
=========================================
  Hits           4377     4377           
  Misses          724      724           
  Partials        447      447           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wslulciuc

@phixMe phixMe merged commit 48f4a60 into main Jun 14, 2022
@phixMe phixMe deleted the feature/reduce-limit-for-list-datasets-jobs branch June 14, 2022 23:51
@wslulciuc wslulciuc changed the title Reduce UI limit for list datasets jobs in UI Reduce limit for list datasets jobs in UI Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants