Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column lineage java client #2163

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

pawel-big-lebowski
Copy link
Collaborator

@pawel-big-lebowski pawel-big-lebowski commented Oct 5, 2022

Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com

Problem

Marquez API client methods for column lineage are missing.

Closes: #2163

Solution

Implement Java client.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@pawel-big-lebowski pawel-big-lebowski changed the title Column lineage marquez java client Column lineage java client Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #2163 (e6bd732) into main (9316120) will increase coverage by 0.05%.
The diff coverage is 79.24%.

@@             Coverage Diff              @@
##               main    #2163      +/-   ##
============================================
+ Coverage     76.54%   76.60%   +0.05%     
- Complexity     1108     1136      +28     
============================================
  Files           214      219       +5     
  Lines          5181     5287     +106     
  Branches        408      420      +12     
============================================
+ Hits           3966     4050      +84     
- Misses          760      765       +5     
- Partials        455      472      +17     
Impacted Files Coverage Δ
api/src/main/java/marquez/db/ColumnLineageDao.java 100.00% <ø> (ø)
...a/marquez/client/models/ColumnLineageNodeData.java 0.00% <0.00%> (ø)
...java/src/main/java/marquez/client/models/Node.java 55.55% <55.55%> (ø)
...va/src/main/java/marquez/client/MarquezClient.java 60.35% <65.00%> (+0.44%) ⬆️
...java/src/main/java/marquez/client/models/Edge.java 80.00% <80.00%> (ø)
...va/src/main/java/marquez/client/models/NodeId.java 83.67% <83.67%> (ø)
...va/src/main/java/marquez/client/MarquezPathV1.java 62.90% <100.00%> (+0.60%) ⬆️
.../java/src/main/java/marquez/client/MarquezUrl.java 65.75% <100.00%> (+5.43%) ⬆️
...ients/java/src/main/java/marquez/client/Utils.java 87.09% <100.00%> (+2.48%) ⬆️
.../src/main/java/marquez/client/models/NodeType.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pawel-big-lebowski pawel-big-lebowski force-pushed the downstream-column-lineage branch 3 times, most recently from 2e848b4 to b23be06 Compare October 11, 2022 09:33
Base automatically changed from downstream-column-lineage to main October 11, 2022 09:48
@boring-cyborg boring-cyborg bot added api API layer changes docs labels Oct 11, 2022
@pawel-big-lebowski pawel-big-lebowski force-pushed the column-lineage-java-client branch 2 times, most recently from 804adf6 to 7a9904e Compare October 12, 2022 13:15
@pawel-big-lebowski pawel-big-lebowski force-pushed the column-lineage-java-client branch 2 times, most recently from 412be8b to 1069125 Compare October 13, 2022 07:33
@pawel-big-lebowski pawel-big-lebowski marked this pull request as ready for review October 13, 2022 07:39
@pawel-big-lebowski pawel-big-lebowski force-pushed the column-lineage-java-client branch 3 times, most recently from 13e4835 to 6560467 Compare October 13, 2022 11:35
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
@pawel-big-lebowski pawel-big-lebowski merged commit 5265c92 into main Oct 13, 2022
@pawel-big-lebowski pawel-big-lebowski deleted the column-lineage-java-client branch October 13, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants