Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing api spec issues. #2178

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fixing api spec issues. #2178

merged 2 commits into from
Oct 11, 2022

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Oct 10, 2022

Problem

The API spec file was having some issues with type generators for some our putDataset api that is deprecated.

Solution

The spec file is now fixed.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the spec label Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #2178 (7f36639) into main (472e88c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2178   +/-   ##
=========================================
  Coverage     76.56%   76.56%           
  Complexity     1109     1109           
=========================================
  Files           214      214           
  Lines          5181     5181           
  Branches        408      408           
=========================================
  Hits           3967     3967           
  Misses          759      759           
  Partials        455      455           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phixMe phixMe marked this pull request as ready for review October 11, 2022 16:56
@phixMe phixMe added the review Ready for review label Oct 11, 2022
Copy link
Collaborator

@fm100 fm100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@collado-mike collado-mike merged commit 7b6265d into main Oct 11, 2022
@collado-mike collado-mike deleted the fix/api-spec branch October 11, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Ready for review spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants