Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appreciate column prefix when given for ended_at #2231

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

fm100
Copy link
Collaborator

@fm100 fm100 commented Nov 4, 2022

Signed-off-by: Minkyu Park minkyu.park.200@gmail.com

Problem

ended_at column is always null when querying if the columnPrefix is given for the mapper.

Solution

Include columnPrefix when checking column existence.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Minkyu Park <minkyu.park.200@gmail.com>
@fm100 fm100 requested a review from wslulciuc November 4, 2022 22:26
@boring-cyborg boring-cyborg bot added the api API layer changes label Nov 4, 2022
Copy link
Collaborator

@collado-mike collado-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! 🤦🏽‍♂️

@fm100 fm100 enabled auto-merge (squash) November 4, 2022 22:54
@fm100 fm100 merged commit 17f27d3 into MarquezProject:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants