Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update prettier and eslint version for optional chaining support #2393

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

tito12
Copy link
Contributor

@tito12 tito12 commented Feb 3, 2023

Problem

Current version of eslint and prettier not support optional chaining which make code more clean and readable

Solution

This PR provide those changes with updated version for this package to pass tests for new ecmascript features as "optional chaining"

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@phixMe
Copy link
Member

phixMe commented Feb 6, 2023

You should have some lock file changes with this one correct?

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@tito12
Copy link
Contributor Author

tito12 commented Feb 7, 2023

You should have some lock file changes with this one correct?

My bad, already added, thanks for remark

@tito12 tito12 enabled auto-merge (squash) February 7, 2023 20:05
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@tito12 tito12 merged commit d209bdd into main Feb 7, 2023
@tito12 tito12 deleted the web/prettier-eslint-version branch February 7, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants