Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage UI: Add a graph depth config option #2525

Merged
merged 9 commits into from
Jun 21, 2023

Conversation

jlukenoff
Copy link
Contributor

@jlukenoff jlukenoff commented Jun 20, 2023

Problem

Currently for very large lineage graphs, it can be hard to navigate the graph by dragging and zooming.

Closes: #2378

Solution

This PR adds an option to the lineage graph UI where the user can select the depth of the lineage graph.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
@boring-cyborg boring-cyborg bot added the web label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #2525 (58cc1e7) into main (00b799b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2525   +/-   ##
=========================================
  Coverage     83.80%   83.80%           
  Complexity     1233     1233           
=========================================
  Files           235      235           
  Lines          5625     5625           
  Branches        270      270           
=========================================
  Hits           4714     4714           
  Misses          767      767           
  Partials        144      144           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
@jlukenoff
Copy link
Contributor Author

I just added this as floating in the upper right-hand corner for now. Happy to move it wherever it makes the most sense, although this feels pretty usable to me

output

@jlukenoff jlukenoff marked this pull request as ready for review June 20, 2023 14:22
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
@phixMe phixMe self-requested a review June 20, 2023 16:38
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
@jlukenoff jlukenoff requested a review from phixMe June 20, 2023 17:08
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlukenoff 🐑 it!

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
@boring-cyborg boring-cyborg bot added the docs label Jun 20, 2023
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
@jlukenoff
Copy link
Contributor Author

Thanks @phixMe ! Just added an entry to the changelog. Would you mind merging? I don't have write access yet

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Let's favor usability for now and 🚢 it as is!

@wslulciuc wslulciuc merged commit d6cf0b0 into MarquezProject:main Jun 21, 2023
@jlukenoff jlukenoff deleted the ui/lineage/depth-config branch June 22, 2023 17:21
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 5, 2023
* stuff

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add headers

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Fix zindex

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add minimum

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* hmm

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* retry

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Update default depth

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add an entry to the Changlog

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Dont reformat everything

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

---------

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Xavier-Cliquennois added a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 5, 2023
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
* stuff

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add headers

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Fix zindex

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add minimum

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* hmm

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* retry

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Update default depth

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add an entry to the Changlog

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Dont reformat everything

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

---------

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois added a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
* stuff

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add headers

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Fix zindex

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add minimum

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* hmm

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* retry

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Update default depth

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add an entry to the Changlog

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Dont reformat everything

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

---------

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
* stuff

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add headers

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Fix zindex

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add minimum

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* hmm

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* retry

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Update default depth

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add an entry to the Changlog

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Dont reformat everything

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

---------

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois added a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
* stuff

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add headers

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Fix zindex

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add minimum

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* hmm

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* retry

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Update default depth

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Add an entry to the Changlog

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

* Dont reformat everything

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>

---------

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to set depth of lineage graph in UI
3 participants