Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text in calibration process #754

Merged

Conversation

BarbourSmith
Copy link
Member

Makes some tweaks to the instructions of the step to measure the distance between the motors as recommended here:

https://forums.maslowcnc.com/t/ground-control-calibration-problem/5187/42

This is how the new step looks:

image

@MaslowCommunityGardenRobot
Copy link
Collaborator

Congratulations on the pull request @BarbourSmith

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

@MaslowCommunityGardenRobot
Copy link
Collaborator

Time is up and we're ready to merge this pull request. Great work!

@MaslowCommunityGardenRobot MaslowCommunityGardenRobot merged commit 7a5825b into master Aug 15, 2018
@JoePreis
Copy link

JoePreis commented Aug 16, 2018 via email

@servant74
Copy link

Joe,

Pull requests let you tell others about changes you've pushed to a GitHub repository. Once a pull request is sent, interested parties can review the set of changes, discuss potential modifications, and even push follow-up commits if necessary. -- this is a response from a quick Google search.

@BarbourSmith BarbourSmith deleted the Update-text-for-calibration-process branch July 30, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants