Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catch for KeyError exception #781

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

BarbourSmith
Copy link
Member

This exception when a motion was detected while a popup was open was causing the program to crash. No action is needed for this exception so it is now captured silently.

Fixes #780

Please test and up vote this pull request if the fix seams reasonable and works for you!

This exception when a motion was detected while a popup was open was causing the program to crash. No action is needed for this exception so it is now captured silently.

Fixes #780

Please test and upvote this pull request if the fix seams reasonable and works for you!
@MaslowCommunityGardenRobot
Copy link
Collaborator

Congratulations on the pull request @BarbourSmith

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

@blurfl
Copy link
Collaborator

blurfl commented Oct 19, 2018

That was quick! Works as described on the box..

@GeroBH
Copy link
Contributor

GeroBH commented Oct 19, 2018

Tested on linux works like a charm.
Master speed solving!

@MaslowCommunityGardenRobot
Copy link
Collaborator

Time is up and we're ready to merge this pull request. Great work!

@MaslowCommunityGardenRobot MaslowCommunityGardenRobot merged commit 313b4ab into master Oct 21, 2018
@BarbourSmith BarbourSmith deleted the fix-click-outside-popup branch July 30, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

click and drag outside the Z window crasches GC
4 participants