Refactor installer / vcs creation & configuration

[crsmithdev]

As discussed in #372 I am in the process of adding support for URL rewrites. When looking at adding an additional configuration file (.gliderc or similar, TBD), I noted that it would be difficult to add in support for this under the current installer / vcs structure -- some vcs methods, for example, already have 9 parameters, and adding onto that is just going to pile up debt.

So, in preparation for doing that, I've refactored the installer / vcs code a bit to make creating and configuring them a bit more straightforward, and adjusted the method signatures accordingly. This should make adding a new config file and passing config around much more straightforward.

I think there's certainly additional work to be done (further refactors, more testable abstractions, tests) but this seems like a good stopping point for review.

[mattfarina]

@crsmithdev thanks for trying to clean this up. I had a chance to skim it (I'll give it a finer pass later).

From this one question came up. There are both conf and confcopy. The reason confcopy is passed into the installer is because transitive packages are added to this. We need both a pristine copy of conf and a version containing the transitive dependencies for doing things like writing the lock file.

Here is seems the installer skips confcopy (if not I might have missed it). That's going to create some issues.

Does that make sense?

[crsmithdev]

Yes...that was a source of some confusion for me as well. Would a workable approach be to replace the installer / vcs Config value, from conf to confcopy, after confcopy is created, and then swap it back @ the end of whatever function is creating the copy? Or is there a better way, somehow?

[technosophos]

I really like the config structs. Too much organic growth led to some icky function signatures. This is much cleaner.

[crsmithdev]

I've updated this w/ more careful treatment of config copies.

[mattfarina]

Notice the UpdateTracker is attached to the Installer instead of the Vcs. In later calls it's looking for it as a property on Vcs. Can you make the tracker available in both places?

[ascandella]

@crsmithdev would you like me to take over this PR?

[crsmithdev]

@sectioneight yes, is there anything I need to do in order to transfer / reassign to you?

[ascandella]

I think you need to add me as a collaborator on https://github.com/crsmithdev/glide so I can push the branch associated with this PR

[ascandella]

@mattfarina added the Tracker onto the VCS as well

[ascandella]

This is not ready for merging yet though, this appears to have broken something:

[INFO] Fetching updates for golang.org/x/net.
[INFO] Fetching updates for golang.org/x/sys.
[INFO] Fetching updates for gopkg.in/fsnotify.v1.
[INFO] Fetching updates for gopkg.in/validator.v2.
[INFO] Fetching updates for gopkg.in/yaml.v2.
[INFO] Downloading dependencies. Please wait...
[INFO] Setting references.
[ERROR] Failed to set version on github.com/Sirupsen/logrus to be52937128b38f1d99787bb476c789e2af1147f1: open github.com/Sirupsen/logrus: no such file or directory
[ERROR] Failed to set version on github.com/stretchr/testify to ^1.1.3: open github.com/stretchr/testify: no such file or directory
[ERROR] Failed to set version on github.com/spf13/cobra to : Unable to retrieve checked out version

[ascandella]

OK, functionality should be restored now, but I'd like an extra set of eyes on this given that I'm unfamiliar with the code and the path that was broken doesn't seem to be covered by existing tests.

Where would be the best place to add such tests?

[mattfarina]

This is now out of sync and about to be superseded by the gps integration work. Closing.