Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use v3 #125

Closed
prymitive opened this issue Sep 13, 2019 · 2 comments · Fixed by #126
Closed

Cannot use v3 #125

prymitive opened this issue Sep 13, 2019 · 2 comments · Fixed by #126
Labels

Comments

@prymitive
Copy link

prymitive commented Sep 13, 2019

Trying to upgrade to v3.0.0

--- a/go.mod
+++ b/go.mod
@@ -4,7 +4,7 @@ go 1.12
 
 require (
[...]
-       github.com/Masterminds/semver v1.5.0
+       github.com/Masterminds/semver v3.0.0
[...]

but Go wants /v3 suffix on the module:

go: finding github.com/Masterminds/semver v3.0.0
go: finding github.com/Masterminds/semver v3.0.0
go: errors parsing go.mod:
/home/lukasz/work/karma/go.mod:7: require github.com/Masterminds/semver: version "v3.0.0" invalid: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v3

so added it:

--- a/go.mod
+++ b/go.mod
@@ -4,7 +4,7 @@ go 1.12
 
 require (
[...]
-       github.com/Masterminds/semver v1.5.0
+       github.com/Masterminds/semver/v3 v3.0.0
[...]

but getting an error during go build and go mod tidy:

$ go mod tidy
go: github.com/Masterminds/semver/v3@v3.0.0: go.mod has non-.../v3 module path "github.com/Masterminds/semver" (and .../v3/go.mod does not exist) at revision v3.0.0
@mattfarina mattfarina added the bug label Sep 13, 2019
mattfarina added a commit to mattfarina/semver that referenced this issue Sep 13, 2019
mattfarina added a commit to mattfarina/semver that referenced this issue Sep 13, 2019
mattfarina added a commit to mattfarina/semver that referenced this issue Sep 13, 2019
@mattfarina
Copy link
Member

@prymitive Thanks for catching this. It should now be fixed. Try using v3.0.1 with the bugfix.

@medium-joel
Copy link

I'm still encountering this error an am on v3.0.1

idexter pushed a commit to percona/mongodb_exporter that referenced this issue Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants