Fix handling of single digit tilde constraint #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"~2" was documented to work, but did not
dgodd
changed the title
dgodd
added a commit
to dgodd/nodejs-buildpack
that referenced
this pull request
Apr 12, 2017
|
@dgodd good catch. I'll get on this in the next few days. Thanks. |
|
To call it out, the specific doc says..
In this case it basically acts like ^. These rules are confusing... and I wrote that. I can confirm the current implementation doesn't work for this rule. I'm going to research what others do here before I merge this. |
|
NPM (node.js) does:
Cargo (rust) does:
|
mattfarina
reviewed
Apr 19, 2017
| @@ -175,7 +175,7 @@ func parseConstraint(c string) (*constraint, error) { | |||
| if isX(m[3]) { | |||
| ver = "0.0.0" | |||
| dirty = true | |||
| } else if isX(strings.TrimPrefix(m[4], ".")) { | |||
| } else if isX(strings.TrimPrefix(m[4], ".")) || m[4] == "" { | |||
There was a problem hiding this comment.
Note (for my future self): what this does it treat a missing minor element as x instead of 0.
|
@dgodd Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"~2" was documented to work, but did not