Upgrade deps #93
Merged
Upgrade deps #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poteirard
commented
Nov 1, 2020
| @@ -9,7 +9,8 @@ | |||
| "main": "build/index.js", | |||
| "types": "build/index.d.ts", | |||
| "dependencies": { | |||
| "js-cookie": "^2.2.1" | |||
| "js-cookie": "^2.2.1", | |||
| "prop-types": "^15.7.2" | |||
There was a problem hiding this comment.
I added this as suggested in the official docs https://www.npmjs.com/package/prop-types#how-to-depend-on-this-package
poteirard
commented
Nov 1, 2020
| @@ -1,32 +1,30 @@ | |||
| var path = require('path'); | |||
| var CopyWebpackPlugin = require('copy-webpack-plugin'); | |||
| var path = require("path"); | |||
There was a problem hiding this comment.
All this formating comes from git hooks > prettier.
poteirard
commented
Nov 1, 2020
| plugins: [ | ||
| new CopyWebpackPlugin([{ from: 'src/index.d.ts', to: 'index.d.ts' }]) | ||
| ] | ||
| plugins: [new CopyWebpackPlugin({ patterns: [{ from: "src/index.d.ts", to: "index.d.ts" }] })], |
There was a problem hiding this comment.
This is the new syntax according to the official docs
|
Pr looks good. I knew the files weren't up to date with prettier so no worries. I did not the prop-types thing as a dependency. Never used it like that. Guess I need to revisit a lot of projects 😄 Will merge this together with the other one after some tests etc. Thanks again for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to upgrade a lot of libraries in order to fix all the vulnerabilities. Sorry if the PR is too big
Fixes #91 #92