Post SmartHint adoption cleanup #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HintOffset is now only used if explicitly set to a value other than the default; thus a default of (0,0) seems appropriate.
Filling the height of the host window is problematic when a Popup needs to be shown below the control. This causes the window to increase in size and does not really imitate real life usage.
Keboo
added
the
release notes
Keboo
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bit of house-keeping after the
SmartHintchanges have been applied to all relevant templates.HintAssist.FloatingOffsetdefault value down to (0,0) since it is ONLY used if set to something other than the default value; as such, the new default seems more appropriate.AutoSuggestBoxwas allowed to take up all vertical real-estate, thePopupwas shown below the control, causing the window height to grow. This seems wrong and does not really imitate a real life use case.For simplicity, this PR currently replicates the
TextBoxtemplate into theAutoSuggestBox. In the future, we could look into leveraging the existingTextBoxstyle rather than carrying around a copy.