Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-materialize: Store Failures As #23025

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Nov 8, 2023

Motivation

As part of the dbt v1.7.0 upgrade. Modify the ability to store tests as additional materializations with store_failures_as. Tests can be materialized as table, view or materialized view (like models, selecting table will materialize as a materialized view).

  • Project level
tests:
  my_project:
    +store_failures_as: table
  • Model level
models:
  - name: my_model
    columns:
      - name: id
        tests:
          - not_null:
              config:
                store_failures_as: view
          - unique:
              config:
                store_failures_as: materialized_view

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@dehume dehume added the T-dbt Theme: dbt adapter label Nov 8, 2023
@dehume dehume changed the title [WIP] dbt-materialize: Store Failures As dbt-materialize: Store Failures As Nov 9, 2023
@dehume dehume marked this pull request as ready for review November 9, 2023 15:25
@dehume dehume requested a review from a team November 9, 2023 15:25
@morsapaes morsapaes force-pushed the dbt-Store-Test-Failures branch from b7337c7 to 7ae1847 Compare November 15, 2023 23:22
@morsapaes morsapaes requested a review from a team as a code owner November 20, 2023 10:05
@morsapaes morsapaes force-pushed the dbt-Store-Test-Failures branch from aaab048 to 42de180 Compare November 20, 2023 11:07
@morsapaes morsapaes merged commit d7f5b00 into MaterializeInc:main Nov 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-dbt Theme: dbt adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants